Repository navigation
Conversation
r10s
force-pushed
the
r10s/test-webxdc-vs-ephemeral-messages
branch
3 times, most recently
from
November 7, 2026 23:39
d8c5a62 to
5e04ccb
Compare
r10s
force-pushed
the
r10s/test-webxdc-vs-ephemeral-messages
branch
from
November 7, 2026 23:45
5e04ccb to
96c8b67
Compare
link2xt
approved these changes
Nov 8, 2026
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn test_status_update_vs_ephemeral_timer() -> Result<()> { | ||
| let alice = &TestContext::new_alice().await; |
Collaborator
There was a problem hiding this comment.
New tests better use TestContextManager, even if there is only one context, but definitely if there are multiple contexts:
let mut tcm = TestContextManager::new();
let alice = &tcm.alice().await;
let bob = &tcm.bob().await;
This currently has not much advantage since with_log_sink() is removed, but if it is restored or more features are implemented in the context manager, then test will use it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR tests the current state of "Disappearing Messages" being used for apps - actually, status updates do not extend or reset the disappearing messages timer - different to "Delete Message from Device", where this was done explicitly at #5388
there is some confusion about that, at least i have it, and in that regard also the part following "NOTE:" in this forum thread is wrong: https://forum.delta.chat/t/delete-messages-but-not-in-chat-app-updates/5920/2 cc @adbenitez
if we want to have a different behavior, we should still merge this PR, and open a subsequent issue/PR then